[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test |
Date: |
Wed, 7 Feb 2018 12:15:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 06/02/2018 21:30, Roman Kagan wrote:
> + if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) {
> + g_printerr("Hyper-V / VMBus are only available on x86\n");
> + exit(EXIT_FAILURE);
> + }
This shouldn't be needed.
> +
> + if (access("/dev/kvm", R_OK | W_OK)) {
Maybe try opening it too? In theory you could have a /dev/kvm device
that triggers loading the kvm module (see
https://github.com/systemd/systemd/pull/7795 for gory details).
Paolo
> + g_printerr("Hyper-V / VMBus can only be used with KVM\n");
> + exit(EXIT_FAILURE);
> + }
> +
> + return qtest_pc_boot(cmd, extra_opts ? : "");
- Re: [Qemu-devel] [RFC PATCH 23/34] i386: en/disable vmbus by a machine property, (continued)
- [Qemu-devel] [RFC PATCH 26/34] hv-scsi: limit the number of requests per notification, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 24/34] scsi: add Hyper-V/VMBus SCSI protocol definitions, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 20/34] vmbus: vmbus implementation, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 25/34] scsi: add Hyper-V/VMBus SCSI controller, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test, Roman Kagan, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH 28/34] net: add RNDIS definitions, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 31/34] hv-net: add .bootindex support, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 29/34] net: add Hyper-V/VMBus network protocol definitions, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 32/34] loader: allow arbitrary basename for fw_cfg file roms, Roman Kagan, 2018/02/06