[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] qmp: document query-cpus performance issue
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] qmp: document query-cpus performance issue |
Date: |
Wed, 7 Feb 2018 14:14:40 -0500 |
On Wed, 7 Feb 2018 12:50:59 -0600
Eric Blake <address@hidden> wrote:
> On 02/07/2018 11:50 AM, Luiz Capitulino wrote:
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> > qapi-schema.json | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 82d6f12b53..0665a14dba 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -526,6 +526,10 @@
> > #
> > # Returns a list of information about each virtual CPU.
> > #
> > +# WARNING: This command incurs a performance penalty for latency
> > +# sensitive workloads and hence it's not recommended to
> > +# to be used in production. Use query-cpus-fast instead
> > +#
>
> Ah, I asked for this on 1/2. You could squash these.
>
> I didn't review the code, just the interface, so if you squash them, you
> can add the weaker:
>
> Acked-by: Eric Blake <address@hidden>
OK, I'll wait for more review and do the changes you requested.