[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/arm/kvm: gic: Prevent creating userspace
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target/arm/kvm: gic: Prevent creating userspace GICv3 with KVM |
Date: |
Thu, 8 Feb 2018 15:23:38 +0000 |
On 1 February 2018 at 20:53, Christoffer Dall
<address@hidden> wrote:
> KVM doesn't support emulating a GICv3 in userspace, only GICv2. We
> currently attempt this anyway, and as a result a KVM guest doesn't
> receive interrupts and the user is left wondering why. Report an error
> to the user if this particular combination is requested.
>
> Signed-off-by: Christoffer Dall <address@hidden>
> ---
> target/arm/kvm_arm.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h
> index ff53e9fafb..cfb7e5af72 100644
> --- a/target/arm/kvm_arm.h
> +++ b/target/arm/kvm_arm.h
> @@ -234,6 +234,10 @@ static inline const char *gicv3_class_name(void)
> exit(1);
> #endif
> } else {
> + if (kvm_enabled()) {
> + error_report("Userspace GICv3 is not supported with KVM");
> + exit(1);
> + }
> return "arm-gicv3";
> }
Applied to target-arm.next, thanks.
-- PMM