[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] memory: unify loops to sync dirty log bitma
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] memory: unify loops to sync dirty log bitmap |
Date: |
Fri, 9 Feb 2018 12:23:17 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/09/2018 02:45 AM, Paolo Bonzini wrote:
> Now that memory_region_sync_dirty_bitmap is NULL, we can unify its
> loop with memory_global_dirty_log_sync's. The only difference is
> that memory_region_sync_dirty_bitmap will no longer call log_sync on
> FlatRanges that do have a zero dirty_log_mask, but this is okay because
> video memory is always registered with the dirty page logging mechanism.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> memory.c | 23 ++---------------------
> 1 file changed, 2 insertions(+), 21 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, Paolo Bonzini, 2018/02/09
- [Qemu-devel] [PATCH 3/4] memory: introduce memory_global_after_dirty_log_sync, Paolo Bonzini, 2018/02/09
- [Qemu-devel] [PATCH 1/4] memory: remove memory_region_test_and_clear_dirty, Paolo Bonzini, 2018/02/09
- [Qemu-devel] [PATCH 4/4] memory: unify loops to sync dirty log bitmap, Paolo Bonzini, 2018/02/09
- Re: [Qemu-devel] [PATCH 4/4] memory: unify loops to sync dirty log bitmap,
Richard Henderson <=
- [Qemu-devel] [PATCH 2/4] memory: hide memory_region_sync_dirty_bitmap behind DirtyBitmapSnapshot, Paolo Bonzini, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, no-reply, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, no-reply, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, no-reply, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, Dr. David Alan Gilbert, 2018/02/09
- Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG, Dr. David Alan Gilbert, 2018/02/13