[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor.c: Fix infinite loop in monitor's auto-
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] monitor.c: Fix infinite loop in monitor's auto-complete functionality |
Date: |
Tue, 13 Feb 2018 12:46:49 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
* Dimitris Karagkasidis (address@hidden) wrote:
> The QEMU monitor enters an infinite loop when trying to auto-complete commands
> that accept only optional parameters. The commands currently affected by this
> issue are 'info registers' and 'info mtree'.
>
> Signed-off-by: Dimitris Karagkasidis <address@hidden>
Hi Dimitris,
Thanks for that, I guess this has been broken since 48fe86f6.
Your patch does fix it, but I prefer a slightly different fix which I'll
post in a minute, which is a bit more robust to other things going
wrong.
Dave
> ---
> monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor.c b/monitor.c
> index f4992505b1..d8b7270d9b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3741,7 +3741,7 @@ static void monitor_find_completion_by_table(Monitor
> *mon,
> }
> }
> str = args[nb_args - 1];
> - while (*ptype == '-' && ptype[1] != '\0') {
> + while (*ptype == '-' && ptype[2] != '\0') {
> ptype = next_arg_type(ptype);
> }
> switch(*ptype) {
> --
> 2.14.1
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK