[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 28/28] migration/hmp: add migrate_pause comma
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v6 28/28] migration/hmp: add migrate_pause command |
Date: |
Tue, 13 Feb 2018 20:14:53 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
* Peter Xu (address@hidden) wrote:
> Wrapper for QMP command "migrate-pause".
>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hmp-commands.hx | 14 ++++++++++++++
> hmp.c | 9 +++++++++
> hmp.h | 1 +
> 3 files changed, 24 insertions(+)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 7563f3eaa0..32549702ee 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -969,6 +969,20 @@ STEXI
> @item migrate_recover @var{uri}
> @findex migrate_recover
> Continue a paused incoming postcopy migration using the @var{uri}.
> +ETEXI
> +
> + {
> + .name = "migrate_pause",
> + .args_type = "",
> + .params = "",
> + .help = "Pause an ongoing migration (postcopy-only)",
> + .cmd = hmp_migrate_pause,
> + },
> +
> +STEXI
> address@hidden migrate_pause
> address@hidden migrate_pause
> +Pause an ongoing migration. Currently it only supports postcopy.
> ETEXI
>
> {
> diff --git a/hmp.c b/hmp.c
> index 4062d3fdba..ae6266cb21 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1529,6 +1529,15 @@ void hmp_migrate_recover(Monitor *mon, const QDict
> *qdict)
> hmp_handle_error(mon, &err);
> }
>
> +void hmp_migrate_pause(Monitor *mon, const QDict *qdict)
> +{
> + Error *err = NULL;
> +
> + qmp_migrate_pause(&err);
> +
> + hmp_handle_error(mon, &err);
> +}
> +
> /* Kept for backwards compatibility */
> void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict)
> {
> diff --git a/hmp.h b/hmp.h
> index 0d53fe78d9..0aa8dca738 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -71,6 +71,7 @@ void hmp_migrate_cancel(Monitor *mon, const QDict *qdict);
> void hmp_migrate_continue(Monitor *mon, const QDict *qdict);
> void hmp_migrate_incoming(Monitor *mon, const QDict *qdict);
> void hmp_migrate_recover(Monitor *mon, const QDict *qdict);
> +void hmp_migrate_pause(Monitor *mon, const QDict *qdict);
> void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict);
> void hmp_migrate_set_speed(Monitor *mon, const QDict *qdict);
> void hmp_migrate_set_capability(Monitor *mon, const QDict *qdict);
> --
> 2.14.3
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v6 23/28] migration: init dst in migration_object_init too, (continued)
- [Qemu-devel] [PATCH v6 23/28] migration: init dst in migration_object_init too, Peter Xu, 2018/02/08
- [Qemu-devel] [PATCH v6 22/28] migration: final handshake for the resume, Peter Xu, 2018/02/08
- [Qemu-devel] [PATCH v6 25/28] qmp/migration: new command migrate-recover, Peter Xu, 2018/02/08
- [Qemu-devel] [PATCH v6 24/28] io: let watcher of the channel run in same ctx, Peter Xu, 2018/02/08
- [Qemu-devel] [PATCH v6 26/28] hmp/migration: add migrate_recover command, Peter Xu, 2018/02/08
- [Qemu-devel] [PATCH v6 27/28] migration/qmp: add command migrate-pause, Peter Xu, 2018/02/08
- [Qemu-devel] [PATCH v6 28/28] migration/hmp: add migrate_pause command, Peter Xu, 2018/02/08
- Re: [Qemu-devel] [PATCH v6 28/28] migration/hmp: add migrate_pause command,
Dr. David Alan Gilbert <=
- Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery, Peter Xu, 2018/02/08
- Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery, no-reply, 2018/02/08
- Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery, no-reply, 2018/02/08
- Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery, no-reply, 2018/02/08
- Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery, no-reply, 2018/02/08
- Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery, Peter Xu, 2018/02/09
- Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery, no-reply, 2018/02/11