[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails |
Date: |
Thu, 15 Feb 2018 14:41:15 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/15/2018 02:34 PM, Daniel P. Berrangé wrote:
> On Thu, Feb 15, 2018 at 02:23:06PM -0300, Philippe Mathieu-Daudé wrote:
>> Suggested-by: Eric Blake <address@hidden>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> tests/docker/common.rc | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
>> index 7951555e3f..dd011cdf1e 100755
>> --- a/tests/docker/common.rc
>> +++ b/tests/docker/common.rc
>> @@ -30,7 +30,9 @@ build_qemu()
>> $@"
>> echo "Configure options:"
>> echo $config_opts
>> - $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
>> + $QEMU_SRC/configure $config_opts || \
>> + (cat config.log && prep_fail "Failed to run 'configure'")
>> + make $MAKEFLAGS
>> }
>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
>
> Slightly nicer than my patch thanks to the prep_fail addition.
Haha this was a funny experience of parallel programming :)
However your patch has a slightly nicer description!
>
>
> Regards,
> Daniel
>