[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 14/29] hmp: add 'info sev' command
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v9 14/29] hmp: add 'info sev' command |
Date: |
Fri, 16 Feb 2018 17:01:07 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
* Brijesh Singh (address@hidden) wrote:
> The command can be used to show the SEV information when memory
> encryption is enabled on AMD platform.
>
> Cc: Eric Blake <address@hidden>
> Cc: "Daniel P. Berrangé" <address@hidden>
> Cc: "Dr. David Alan Gilbert" <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Brijesh Singh <address@hidden>
That's ok, you might like to add something to decode the policy into a
human readable form.
You might also want to ifdef it for x86 (like info lapic).
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hmp-commands-info.hx | 14 ++++++++++++++
> hmp.c | 19 +++++++++++++++++++
> hmp.h | 1 +
> 3 files changed, 34 insertions(+)
>
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index ad590a4ffb2b..236811c465d2 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -865,6 +865,20 @@ STEXI
> @findex info memory_size_summary
> Display the amount of initially allocated and present hotpluggable (if
> enabled) memory in bytes.
> +ETEXI
> +
> + {
> + .name = "sev",
> + .args_type = "",
> + .params = "",
> + .help = "show SEV information",
> + .cmd = hmp_info_sev,
> + },
> +
> +STEXI
> address@hidden info sev
> address@hidden info sev
> +Show SEV information.
> ETEXI
>
> STEXI
> diff --git a/hmp.c b/hmp.c
> index 7870d6a3004e..f51a107a9be3 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -2924,3 +2924,22 @@ void hmp_info_memory_size_summary(Monitor *mon, const
> QDict *qdict)
> }
> hmp_handle_error(mon, &err);
> }
> +
> +void hmp_info_sev(Monitor *mon, const QDict *qdict)
> +{
> + SevInfo *info;
> +
> + info = qmp_query_sev(NULL);
> + monitor_printf(mon, "sev support: ");
> + monitor_printf(mon, "%s\n", info->enabled ? "enabled" : "disabled");
> +
> + if (info->enabled) {
> + monitor_printf(mon, "state: %s\n", SevState_str(info->state));
> + monitor_printf(mon, "policy: 0x%x\n", info->policy);
> + monitor_printf(mon, "build id: %u\n", info->build_id);
> + monitor_printf(mon, "api version: %u.%u\n",
> + info->api_major, info->api_minor);
> + }
> +
> + qapi_free_SevInfo(info);
> +}
> diff --git a/hmp.h b/hmp.h
> index 1143db44a760..4ca1a77b2c1f 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -146,5 +146,6 @@ void hmp_info_ramblock(Monitor *mon, const QDict *qdict);
> void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict);
> void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict);
> void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict);
> +void hmp_info_sev(Monitor *mon, const QDict *qdict);
>
> #endif
> --
> 2.14.3
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v9 06/29] kvm: update kvm.h to include memory encryption ioctls, (continued)
- [Qemu-devel] [PATCH v9 06/29] kvm: update kvm.h to include memory encryption ioctls, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 02/29] exec: add ram_debug_ops support, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 08/29] target/i386: add Secure Encrypted Virtulization (SEV) object, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 07/29] docs: add AMD Secure Encrypted Virtualization (SEV), Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 09/29] qmp: add query-sev command, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 10/29] sev/i386: add command to initialize the memory encryption context, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 12/29] sev/i386: register the guest memory range which may contain encrypted data, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 11/29] qmp: populate SevInfo fields with SEV guest information, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 15/29] sev/i386: add command to create launch memory encryption context, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 14/29] hmp: add 'info sev' command, Brijesh Singh, 2018/02/15
- Re: [Qemu-devel] [PATCH v9 14/29] hmp: add 'info sev' command,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v9 13/29] kvm: introduce memory encryption APIs, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 16/29] sev/i386: add command to encrypt guest memory region, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 18/29] sev/i386: add support to LAUNCH_MEASURE command, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 20/29] hw/i386: set ram_debug_ops when memory encryption is enabled, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 17/29] target/i386: encrypt bios rom, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 19/29] sev/i386: finalize the SEV guest launch flow, Brijesh Singh, 2018/02/15
- [Qemu-devel] [PATCH v9 21/29] sev/i386: add debug encrypt and decrypt commands, Brijesh Singh, 2018/02/15