Re: [Qemu-devel] [PATCH v2 5/8] net: Remove the deprecated way of dumping network packets

[Eric Blake]

On 02/20/2018 11:40 AM, Thomas Huth wrote:
> "-net dump" has been marked as deprecated since QEMU v2.10, since it
> only works with the deprecated 'vlan' parameter (or hubs). Network
> dumping should be done with "-object filter-dump" nowadays instead.
> Since nobody complained so far about the deprecation message, let's
> finally get rid of "-net dump" now.
>
> Reviewed-by: Paolo Bonzini <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Thomas Huth <address@hidden>
> ---

> +++ b/qapi/net.json
> @@ -39,8 +39,10 @@
>   #
>   # Add a network backend.
>   #
> -# @type: the type of network backend.  Current valid values are 'user', 'tap',
> -#        'vde', 'socket', 'dump' and 'bridge'
> +# @type: the type of network backend. Possible values in version
> +#        2.11: 'user', 'tap', 'vde', 'socket', 'hubport', 'bridge',
> +#              'dump', 'l2tpv3', 'netmap', 'vhost-user'
> +#        2.12: 'dump' dropped
>   #

That's a bit fuzzy, especially since the command has been around since 
0.14.  It might be easier to word it as:

@type: the type of network backend. Possible values are listed in 
NetClientDriver.

Then defer the actual listing by version...

> @@ -468,7 +453,7 @@
>   # Since: 2.7
>   ##
>   { 'enum': 'NetClientDriver',
> -  'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde', 'dump',
> +  'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'vde',
>               'bridge', 'hubport', 'netmap', 'vhost-user' ] }

...to here (although this type only mentions 2.7 as its starting point). 
 (Hmm, I should see if it is worth reviving my attempted patches to 
properly QAPI-fy netdev_add into using a proper schema description - 
when I last proposed it, we ditched it at the last minute because of 
minor incompatibilities in parsing between a QAPI parse and the manual 
parse).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org