[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] qcow2: Don't allow overflow during clust
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] qcow2: Don't allow overflow during cluster allocation |
Date: |
Thu, 22 Feb 2018 11:29:26 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 22 Feb 2018 12:39:52 AM CET, Eric Blake wrote:
> free_in_cluster = s->cluster_size - offset_into_cluster(s, offset);
> do {
> if (!offset || free_in_cluster < size) {
> - int64_t new_cluster = alloc_clusters_noref(bs, s->cluster_size);
> + int64_t new_cluster;
> +
> + new_cluster = alloc_clusters_noref(bs, s->cluster_size,
> + (1ULL << s->csize_shift) - 1);
(1ULL << s->csize_shift) - 1) is the same as s->cluster_offset_mask, but
I guess it's confusing to use that here, so your approach looks
appropriate.
Reviewed-by: Alberto Garcia <address@hidden>
Berto