Re: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when available.

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when 
available.

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3ad392fde0 linux-user: Support f_flags in statfs when available.

=== OUTPUT BEGIN ===
Checking PATCH 1/1: linux-user: Support f_flags in statfs when available....
ERROR: code indent should never use tabs
#70: FILE: linux-user/syscall_defs.h:366:
+^Iint f_frsize;$

ERROR: code indent should never use tabs
#71: FILE: linux-user/syscall_defs.h:367:
+^Iint f_flags;$

ERROR: code indent should never use tabs
#72: FILE: linux-user/syscall_defs.h:368:
+^Iint f_spare[4];$

ERROR: code indent should never use tabs
#85: FILE: linux-user/syscall_defs.h:2234:
+^Iint32_t^I^I^If_flags;$

ERROR: code indent should never use tabs
#86: FILE: linux-user/syscall_defs.h:2235:
+^Iint32_t^I^I^If_spare[5];$

ERROR: code indent should never use tabs
#98: FILE: linux-user/syscall_defs.h:2255:
+^Iabi_long^I^If_flags;$

ERROR: code indent should never use tabs
#99: FILE: linux-user/syscall_defs.h:2256:
+^Iabi_long^I^If_spare[5];$

ERROR: code indent should never use tabs
#111: FILE: linux-user/syscall_defs.h:2276:
+^Iuint32_t^If_flags;$

ERROR: code indent should never use tabs
#112: FILE: linux-user/syscall_defs.h:2277:
+^Iuint32_t^If_spare[5];$

ERROR: code indent should never use tabs
#124: FILE: linux-user/syscall_defs.h:2297:
+^Iabi_long f_flags;$

ERROR: code indent should never use tabs
#125: FILE: linux-user/syscall_defs.h:2298:
+^Iabi_long f_spare[4];$

ERROR: code indent should never use tabs
#137: FILE: linux-user/syscall_defs.h:2316:
+^Iabi_long f_flags;$

ERROR: code indent should never use tabs
#138: FILE: linux-user/syscall_defs.h:2317:
+^Iabi_long f_spare[4];$

ERROR: code indent should never use tabs
#177: FILE: linux-user/syscall_defs.h:2374:
+^Iuint32_t f_flags;$

ERROR: code indent should never use tabs
#178: FILE: linux-user/syscall_defs.h:2375:
+^Iuint32_t f_spare[4];$

ERROR: code indent should never use tabs
#190: FILE: linux-user/syscall_defs.h:2393:
+^Iuint32_t f_flags;$

ERROR: code indent should never use tabs
#191: FILE: linux-user/syscall_defs.h:2394:
+^Iuint32_t f_spare[4];$

total: 17 errors, 0 warnings, 164 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden