[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 0/5] Initial write support for MTP objects
From: |
Bandan Das |
Subject: |
[Qemu-devel] [PATCH v5 0/5] Initial write support for MTP objects |
Date: |
Thu, 22 Feb 2018 14:57:35 -0500 |
v5:
4/5,5/5: Add check for the RO bit and set response to STORE_READ_ONLY
v4:
4/5: Remove getumask and set default permissions to 0644
5/5: Remove usb_mtp_object_lookup_name out of #ifdef CONFIG_INOTIFY1
Test compilation on freebsd
v3:
3/5: Add a property that sets r/w to on/off (default:off)
Restructure ifdefs
4/5: Sort the response codes
5/5: Use actual names for fields in the dataset
Copy uint16_t to wchar_t and use wcstombs to get char type
for filename
v2:
3/5: Set mtp store flag to read only
4/5: Fix compiler warnings and change default file permissions
5/5: Fix file permissions
These patches implement write support for Qemu's MTP
emulation. Simple tests such as delete/move/edit/copy work ok.
Current issues/TODO:
- File transfers > 4GB has not been tested and will probably not work
- Some (or most) MTP clients don't advertise hidden files and folders (names
that start with a .) even though iiuc Qemu MTP does advertise these files.
This can confuse certain applications such as text editors or git.
- Also related, file editors typically run fsync when saving. Depending on
the MTP client, it may choose not to implement it (such as simple-mtpfs that
runs on top of fuse).
- Needs more testing :)
Bandan Das (5):
usb-mtp: Add one more argument when building results
usb-mtp: print parent path in IN_IGNORED trace fn
usb-mtp: Support delete of mtp objects
usb-mtp: Introduce write support for MTP objects
usb-mtp: Advertise SendObjectInfo for write support
hw/usb/dev-mtp.c | 471 +++++++++++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 441 insertions(+), 30 deletions(-)
--
2.14.3
- [Qemu-devel] [PATCH v5 0/5] Initial write support for MTP objects,
Bandan Das <=
- [Qemu-devel] [PATCH v5 2/5] usb-mtp: print parent path in IN_IGNORED trace fn, Bandan Das, 2018/02/22
- [Qemu-devel] [PATCH v5 5/5] usb-mtp: Advertise SendObjectInfo for write support, Bandan Das, 2018/02/22
- [Qemu-devel] [PATCH v5 4/5] usb-mtp: Introduce write support for MTP objects, Bandan Das, 2018/02/22
- [Qemu-devel] [PATCH v5 3/5] usb-mtp: Support delete of mtp objects, Bandan Das, 2018/02/22
- [Qemu-devel] [PATCH v5 1/5] usb-mtp: Add one more argument when building results, Bandan Das, 2018/02/22
- Re: [Qemu-devel] [PATCH v5 0/5] Initial write support for MTP objects, no-reply, 2018/02/22