[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH RFC] scripts/checkpatch.pl:Add check for `while` and
From: |
Su Hang |
Subject: |
[Qemu-devel] [PATCH RFC] scripts/checkpatch.pl:Add check for `while` and `for` |
Date: |
Sat, 24 Feb 2018 21:54:18 +0800 |
Add check for `while` and `for` statement, which condition has more than
one line.
The former checkpatch.pl can check `if` statement, which condition has more
than one line, whether block misses brace round, like this:
'''
if (cond1 ||
cond2)
statement;
'''
But it doesn't do the same check for `for` and `while`.
Suggested-by: Eric Blake <address@hidden>
Suggested-by: Thomas Huth <address@hidden>
Signed-off-by: Su Hang <address@hidden>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 1b4b812e28fa..cfe7e77d156f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2353,7 +2353,7 @@ sub process {
}
# check for missing bracing round if etc
- if ($line =~ /(^.*)\bif\b/ && $line !~ /\#\s*if/) {
+ if ($line =~ /(^.*)\b(if|for|while)\b/ && $line !~
/\#\s*(if|for|while)/) {
my ($level, $endln, @chunks) =
ctx_statement_full($linenr, $realcnt, 1);
if ($dbg_adv_apw) {
--
2.7.4
- [Qemu-devel] [PATCH RFC] scripts/checkpatch.pl:Add check for `while` and `for`,
Su Hang <=