Re: [Qemu-devel] [PATCH v3] scripts/checkpatch.pl: add check for `while` and `for`

[Darren Kenny]

On Wed, Feb 28, 2018 at 11:31:29AM +0800, Su Hang wrote:
> Adding check for `while` and `for` statements, which condition has more than
> one line.
>
> The former checkpatch.pl can check `if` statement, which condition has more
> than one line, whether block misses brace round, like this:
> '''
> if (cond1 ||
>    cond2)
>    statement;
> '''
> But it doesn't do the same check for `for` and `while` statements.
>
> Using `(?:...)` instead of `(...)` in regex pattern catch.
> Because `(?:...)` is faster and avoids unwanted side-effect.
>
> Suggested-by: Stefan Hajnoczi <address@hidden>
> Suggested-by: Eric Blake <address@hidden>
> Suggested-by: Thomas Huth <address@hidden>
> Signed-off-by: Su Hang <address@hidden>
> ---
> scripts/checkpatch.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 10c138344fa9..bed1dbbd54d1 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2352,9 +2352,9 @@ sub process {
>                         }
>                 }
>
> -# check for missing bracing round if etc
> -               if ($line =~ /(^.*)\b(for|while|if)\b/ &&
> -                       $line !~ /\#\s*(for|while|if)/) {
> +# check for missing bracing around if etc
> +               if ($line =~ /(^.*)\b(?:for|while|if)\b/ &&
> +                       $line !~ /\#\s*(?:for|while|if)/) {

It's a nit, but for readability I would suggest indenting the line
above an extra tab or two to make it clear that it is part of the
condition rather than the block. (You can see other instances of
this in the file).

Otherwise:

Reviewed-by: Darren Kenny <address@hidden>

Thanks,

Darren.


>                         my ($level, $endln, @chunks) =
>                                 ctx_statement_full($linenr, $realcnt, 1);
>                         if ($dbg_adv_apw) {
> --
> 2.7.4