[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/15] chardev: allow telnet gsource to switc
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 08/15] chardev: allow telnet gsource to switch gcontext |
|
Date: |
Thu, 1 Mar 2018 18:16:53 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 01/03/2018 16:46, Daniel P. Berrangé wrote:
> On Thu, Mar 01, 2018 at 04:44:31PM +0800, Peter Xu wrote:
>> It was originally created by qio_channel_add_watch() so it's always
>> assigning the task to main context. Now we use the new API called
>> qio_channel_add_watch_source() so that we get the GSource handle rather
>> than the tag ID.
>>
>> Meanwhile, caching the gsource in SocketChardev.telnet_source so that we
>> can also do dynamic context switch when update read handlers.
> I don't see why we would ever want to dynamically switch the
> GMainContext in use while in middle of reading the telnet greeting.
Maybe because the remote client hangs in the middle of the telnet
greeting? The user of the Chardev can't know that the initial handshake
hasn't been done yet.
Paolo
- Re: [Qemu-devel] [PATCH v2 06/15] qio: store gsources for net listeners, (continued)
[Qemu-devel] [PATCH v2 08/15] chardev: allow telnet gsource to switch gcontext, Peter Xu, 2018/03/01
[Qemu-devel] [PATCH v2 10/15] qio: non-default context for async conn, Peter Xu, 2018/03/01
[Qemu-devel] [PATCH v2 09/15] qio: non-default context for threaded qtask, Peter Xu, 2018/03/01
[Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS handshake, Peter Xu, 2018/03/01