[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settin
From: |
Jason Baron |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net |
Date: |
Fri, 2 Mar 2018 11:59:00 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 03/02/2018 02:14 AM, Jason Wang wrote:
>
>
> On 2018年03月02日 11:46, Jason Baron wrote:
>> Although linkspeed and duplex can be set in a linux guest via 'ethtool
>> -s',
>> this requires custom ethtool commands for virtio-net by default.
>>
>> Introduce a new feature flag, VIRTIO_NET_F_SPEED_DUPLEX, which allows
>> the hypervisor to export a linkspeed and duplex setting. The user can
>> subsequently overwrite it later if desired via: 'ethtool -s'.
>>
>> Linkspeed and duplex settings can be set as:
>> '-device virtio-net,speed=10000,duplex=full'
>
> I was thinking whether or not it's better to decide the duplex by the
> type of backends.
>
> E.g userspace and vhost-kernel implement a in fact half duplex. But dpdk
> implement a full duplex.
Interesting - could this be derived only from the backend 'type'. IE:
NET_CLIENT_DRIVER_TAP, NET_CLIENT_DRIVER_VHOST_USER...
I was also thinking this could be specified as 'duplex=backend', in
addition to the proposed 'duplex=full' or 'duplex=half'?
Thanks,
-Jason
>
> Thanks
>
>>
>> where speed is [0...INT_MAX], and duplex is ["half"|"full"].
>>
>> Signed-off-by: Jason Baron<address@hidden>
>> Cc: "Michael S. Tsirkin"<address@hidden>
>> Cc: Jason Wang<address@hidden>
>> Cc:address@hidden
>> ---
>
- [Qemu-devel] [PATCH 1/4] eth: add speed and duplex definitions, (continued)
[Qemu-devel] [PATCH 2/4] rocker: drop local duplex definitions, Jason Baron, 2018/03/01
[Qemu-devel] [PATCH 3/4] virtio-net: use 64-bit values for feature flags, Jason Baron, 2018/03/01
[Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Jason Baron, 2018/03/01
Re: [Qemu-devel] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Michael S. Tsirkin, 2018/03/02
Re: [Qemu-devel] [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Yan Vugenfirer, 2018/03/04
Re: [Qemu-devel] [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Jason Baron, 2018/03/06
Re: [Qemu-devel] [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Michael S. Tsirkin, 2018/03/06
Re: [Qemu-devel] [virtio-dev] [PATCH 4/4] virtio-net: add linkspeed and duplex settings to virtio-net, Yan Vugenfirer, 2018/03/08
Re: [Qemu-devel] [PATCH 0/4] virtio-net: allow linkspeed and duplex setting, no-reply, 2018/03/01
Re: [Qemu-devel] [PATCH 0/4] virtio-net: allow linkspeed and duplex setting, no-reply, 2018/03/01
Re: [Qemu-devel] [PATCH 0/4] virtio-net: allow linkspeed and duplex setting, no-reply, 2018/03/01