[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/9] chardev: qio related non-default context su
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 0/9] chardev: qio related non-default context support |
Date: |
Mon, 5 Mar 2018 15:59:54 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Sun, Mar 04, 2018 at 11:43:39PM -0800, address@hidden wrote:
[...]
> TEST decodetree.py
> LINK tests/check-qdict
> LINK tests/test-char
> LINK tests/check-qnum
> LINK tests/check-qstring
> LINK tests/check-qlist
> LINK tests/check-qnull
> tests/test-char.o: In function `char_mux_test':
> /tmp/qemu-test/src/tests/test-char.c:169: undefined reference to
> `muxes_realized'
This is a valid report.
I need to squash this into patch 5 to fix it:
diff --git a/include/chardev/char-mux.h b/include/chardev/char-mux.h
index 8928977897..1e13187767 100644
--- a/include/chardev/char-mux.h
+++ b/include/chardev/char-mux.h
@@ -27,8 +27,6 @@
#include "chardev/char.h"
#include "chardev/char-fe.h"
-extern bool muxes_realized;
-
#define MAX_MUX 4
#define MUX_BUFFER_SIZE 32 /* Must be a power of 2. */
#define MUX_BUFFER_MASK (MUX_BUFFER_SIZE - 1)
diff --git a/tests/test-char.c b/tests/test-char.c
index b358620911..e49af9e398 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -166,7 +166,6 @@ static void char_mux_test(void)
FeHandler h1 = { 0, }, h2 = { 0, };
CharBackend chr_be1, chr_be2;
- muxes_realized = true; /* done after machine init */
opts = qemu_opts_create(qemu_find_opts("chardev"), "mux-label",
1, &error_abort);
qemu_opt_set(opts, "backend", "ringbuf", &error_abort);
I'll repost until I got some other feedbacks.
--
Peter Xu
- Re: [Qemu-devel] [PATCH 3/9] chardev: update net listener gcontext, (continued)
- [Qemu-devel] [PATCH 4/9] chardev: allow telnet gsource to switch gcontext, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 6/9] chardev: use chardev's gcontext for async connect, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 5/9] chardev: introduce chr_machine_done hook, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 7/9] chardev: tcp: postpone async connection setup, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 8/9] chardev: tcp: let TLS run on chardev context, Peter Xu, 2018/03/05
- [Qemu-devel] [PATCH 9/9] chardev: tcp: postpone TLS work until machine done, Peter Xu, 2018/03/05
- Re: [Qemu-devel] [PATCH 0/9] chardev: qio related non-default context support, no-reply, 2018/03/05
- Re: [Qemu-devel] [PATCH 0/9] chardev: qio related non-default context support,
Peter Xu <=