[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/30] hw/i386: use the BYTE-based definitions
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 08/30] hw/i386: use the BYTE-based definitions |
Date: |
Mon, 5 Mar 2018 13:29:15 +0100 |
On Thu, 15 Feb 2018 01:28:38 -0300
Philippe Mathieu-Daudé <address@hidden> wrote:
> It ease code review, unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
[...]
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index deb440f286..9ccc6192b5 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -2320,8 +2320,8 @@ build_tpm2(GArray *table_data, BIOSLinker *linker,
> GArray *tcpalog)
> (void *)tpm2_ptr, "TPM2", sizeof(*tpm2_ptr), 4, NULL, NULL);
> }
>
> -#define HOLE_640K_START (640 * 1024)
> -#define HOLE_640K_END (1024 * 1024)
> +#define HOLE_640K_START (640 * K_BYTE)
> +#define HOLE_640K_END (1024 * K_BYTE)
nit:
could be 1 * M_BYTE
[...]
Reviewed-by: Igor Mammedov <address@hidden>
- Re: [Qemu-devel] [PATCH 08/30] hw/i386: use the BYTE-based definitions,
Igor Mammedov <=