[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 22/30] hw/display: use the BYTE-based definit
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH v2 22/30] hw/display: use the BYTE-based definitions |
Date: |
Mon, 5 Mar 2018 18:52:51 +0000 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Mon, Mar 05, 2018 at 08:27:24AM -0300, Philippe Mathieu-Daudé wrote:
> It eases code review, unit is explicit.
>
> Patch generated using:
>
> $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
>
> and modified manually.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Gerd Hoffmann <address@hidden>
> ---
> hw/display/xenfb.c | 2 +-
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index f5afcc0358..1ae660519a 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -889,7 +889,7 @@ static int fb_initialise(struct XenDevice *xendev)
> return rc;
>
> fb_page = fb->c.page;
> - rc = xenfb_configure_fb(fb, videoram * 1024 * 1024U,
> + rc = xenfb_configure_fb(fb, videoram * M_BYTE,
> fb_page->width, fb_page->height, fb_page->depth,
> fb_page->mem_length, 0, fb_page->line_length);
> if (rc != 0)
Acked-by: Anthony PERARD <address@hidden>
Thanks,
--
Anthony PERARD
- [Qemu-devel] [PATCH v2 25/30] hw/scsi: use the BYTE-based definitions, (continued)
- [Qemu-devel] [PATCH v2 25/30] hw/scsi: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [PATCH v2 24/30] hw/ipack: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [PATCH v2 26/30] hw/smbios: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [PATCH v2 23/30] hw/net: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [PATCH v2 29/30] tpm: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [PATCH v2 27/30] vfio/pci: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [PATCH v2 30/30] xen: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-devel] [PATCH v2 28/30] ivshmem: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- Message not available
- Re: [Qemu-devel] [PATCH v2 22/30] hw/display: use the BYTE-based definitions,
Anthony PERARD <=