Re: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed size integer types

[Fam Zheng]

On Tue, 03/06 16:20, Daniel P. Berrangé wrote:
> On Tue, Mar 06, 2018 at 08:05:18AM -0800, address@hidden wrote:
> > Hi,
> > 
> > This series failed address@hidden build test. Please find the testing 
> > commands and
> > their output below. If you have Docker installed, you can probably 
> > reproduce it
> > locally.
> > 
> > Type: series
> > Message-id: address@hidden
> > Subject: [Qemu-devel] [PATCH] trace: only permit standard C types and fixed 
> > size integer types
> > 
> > Traceback (most recent call last):
> >   File "/tmp/qemu-test/src/scripts/tracetool.py", line 154, in <module>
> >     main(sys.argv)
> >   File "/tmp/qemu-test/src/scripts/tracetool.py", line 145, in main
> >     events.extend(tracetool.read_events(fh))
> >   File "/tmp/qemu-test/src/scripts/tracetool/__init__.py", line 358, in 
> > read_events
> >     event = Event.build(line)
> >   File "/tmp/qemu-test/src/scripts/tracetool/__init__.py", line 280, in 
> > build
> >     args = Arguments.build(groups["args"])
> >   File "/tmp/qemu-test/src/scripts/tracetool/__init__.py", line 134, in 
> > build
> >     validate_type(arg_type)
> >   File "/tmp/qemu-test/src/scripts/tracetool/__init__.py", line 87, in 
> > validate_type
> >     "declared as 'void *'" % name)
> > ValueError: Error on line 95: Argument type 'hwaddr' is not in whitelist. 
> > Only standard C types and fixed size integer types should be used. struct, 
> > union, and other complex pointer types should be declared as 'void *'
> 
> 
> This nicely illustrates this patch working as documented !
> 
> The fix for the "hwaddr" mistake was just merged in QEMU git master, so
> if patchew can be re-run, applying to latest master it should pass.

Manually initiated re-apply and re-run.

Fam