[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/5] nbd/server: fix: check client->closing before r
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH 3/5] nbd/server: fix: check client->closing before reply sending |
Date: |
Thu, 8 Mar 2018 21:46:34 +0300 |
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
It's like an RFC. I'm not sure, but this place looks like a bug. Shouldn't
we chack client-closing even before nbd_client_receive_next_request() call?
nbd/server.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/nbd/server.c b/nbd/server.c
index e0de431e10..97b45a21fa 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -1547,10 +1547,6 @@ static coroutine_fn void nbd_trip(void *opaque)
goto disconnect;
}
- if (ret < 0) {
- goto reply;
- }
-
if (client->closing) {
/*
* The client may be closed when we are blocked in
@@ -1559,6 +1555,10 @@ static coroutine_fn void nbd_trip(void *opaque)
goto done;
}
+ if (ret < 0) {
+ goto reply;
+ }
+
switch (request.type) {
case NBD_CMD_READ:
/* XXX: NBD Protocol only documents use of FUA with WRITE */
--
2.11.1
- [Qemu-devel] [PATCH 0/5] nbd server fixing and refactoring before BLOCK_STATUS, Vladimir Sementsov-Ogievskiy, 2018/03/08
- [Qemu-devel] [PATCH v2 2/5] nbd/server: fix sparse read, Vladimir Sementsov-Ogievskiy, 2018/03/08
- [Qemu-devel] [PATCH 4/5] nbd/server: refactor nbd_trip: cmd_read and generic reply, Vladimir Sementsov-Ogievskiy, 2018/03/08
- [Qemu-devel] [PATCH 5/5] nbd/server: refactor nbd_trip: split out nbd_handle_request, Vladimir Sementsov-Ogievskiy, 2018/03/08
- [Qemu-devel] [PATCH 3/5] nbd/server: fix: check client->closing before reply sending,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH 1/5] nbd/server: move nbd_co_send_structured_error up, Vladimir Sementsov-Ogievskiy, 2018/03/08
- Re: [Qemu-devel] [PATCH 0/5] nbd server fixing and refactoring before BLOCK_STATUS, Eric Blake, 2018/03/09
- Re: [Qemu-devel] [PATCH 0/5] nbd server fixing and refactoring before BLOCK_STATUS, Eric Blake, 2018/03/12