[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches |
Date: |
Fri, 9 Mar 2018 10:44:03 +0100 |
User-agent: |
NeoMutt/20180223 |
On Fri, Mar 09, 2018 at 10:15:33AM +0100, Gerd Hoffmann wrote:
> On Fri, Mar 09, 2018 at 09:46:44AM +0100, Thomas Huth wrote:
> > On 09.03.2018 08:50, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > >> Maybe I should move the code to a separate source file so it can be
> > >> built with different compiler flags, without needing #pragma? I don't
> > >> feel like building all gtk code with -Wno-deprecated-declarations ...
> > >
> > > Hmm, that idea doesn't fly, seems per-object cflags don't work for
> > > object files which get linked into a module.
> > >
> > > Other ideas anyone?
> >
> > Maybe simply remove the '#pragma GCC diagnostic ignored
> > "-Wunused-but-set-variable"' from the configure test and change
> > util/coroutine-ucontext.c:
>
> I'll try. Will probably have the effect that freebsd builds with
> -Werror then (which is now turned off by configure due to missing
> pragma support), which might trigger more issues ...
Well, guessed almost right. -Werror is enabled on linux only, so
freebsd builds do not fail. But clang builds on linux fail, due to a
bunch of warnings (now errors) about unaligned access to struct members.
cheers,
Gerd
- [Qemu-devel] [PULL 1/8] make: switch language file build to be gtk module aware, (continued)
- [Qemu-devel] [PULL 1/8] make: switch language file build to be gtk module aware, Gerd Hoffmann, 2018/03/08
- [Qemu-devel] [PULL 6/8] ui/gtk: use GtkGlArea on wayland only, Gerd Hoffmann, 2018/03/08
- [Qemu-devel] [PULL 7/8] ui/gtk-egl: add scanout_dmabuf support, Gerd Hoffmann, 2018/03/08
- [Qemu-devel] [PULL 3/8] ui/gtk: make GtkGlArea usage a runtime option, Gerd Hoffmann, 2018/03/08
- [Qemu-devel] [PULL 5/8] ui/opengl: Makefile cleanup, Gerd Hoffmann, 2018/03/08
- Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches, Peter Maydell, 2018/03/08
- Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches, Gerd Hoffmann, 2018/03/09
- Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches, Gerd Hoffmann, 2018/03/09
- Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches, Thomas Huth, 2018/03/09
- Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches, Gerd Hoffmann, 2018/03/09
- Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches, Thomas Huth, 2018/03/09
- Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches, Gerd Hoffmann, 2018/03/09
- Re: [Qemu-devel] [PULL 0/8] Ui 20180308 patches, Peter Maydell, 2018/03/09