Re: [Qemu-devel] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to *_unrealize

[Pierre Morel]

On 09/03/2018 11:27, Cornelia Huck wrote:
> On Fri, 9 Mar 2018 10:23:31 +0100
> Pierre Morel <address@hidden> wrote:
>
> > On 07/03/2018 17:29, Nia Alarie wrote:
> > > Signed-off-by: Nia Alarie <address@hidden>
> > What you do seems right to me, naming seems more logical, but  can you
> > please
> > add a little commit message explaining why you change the interface?
> I had asked Nia to do this; see the comments in qdev-core.h regarding
> usage of exit vs. unrealize.

OK thanks.

> (I have already queued this for a pull request, since I'll be out
> starting tomorrow.)

have fun where you go. :)

See you.
bye

> > Thanks,
> >
> > Pierre
> >
> > > ---
> > >    hw/s390x/virtio-ccw.c | 34 +++++++++++++++++-----------------
> > >    hw/s390x/virtio-ccw.h |  2 +-
> > >    2 files changed, 18 insertions(+), 18 deletions(-)


--
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany