[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/7] OvmfPkg: add customized Tcg2ConfigPei cl
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/7] OvmfPkg: add customized Tcg2ConfigPei clone |
Date: |
Fri, 9 Mar 2018 17:35:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/09/18 14:09, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> The Tcg2ConfigPei module informs the firmware globally about the TPM
> device type, by setting the PcdTpmInstanceGuid PCD to the appropriate
> GUID value. The original module under SecurityPkg can perform device
> detection, or read a cached value from a non-volatile UEFI variable.
>
> OvmfPkg's clone of the module only performs the TPM2 hardware detection.
>
> This is what the module does:
>
> - Check the QEMU hardware for TPM2 availability only
>
> - If found, set the dynamic PCD "PcdTpmInstanceGuid" to
> &gEfiTpmDeviceInstanceTpm20DtpmGuid. This is what informs the rest of
> the firmware about the TPM type.
>
> - Install the gEfiTpmDeviceSelectedGuid PPI. This action permits the
> PEI_CORE to dispatch the Tcg2Pei module, which consumes the above PCD.
> In effect, the gEfiTpmDeviceSelectedGuid PPI serializes the setting
> and the consumption of the "TPM type" PCD.
>
> - If no TPM2 was found, install gPeiTpmInitializationDonePpiGuid.
> (Normally this is performed by Tcg2Pei, but Tcg2Pei doesn't do it if
> no TPM2 is available. So in that case our Tcg2ConfigPei must do it.)
>
> Cc: Laszlo Ersek <address@hidden>
> Cc: Stefan Berger <address@hidden>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> OvmfPkg/OvmfPkgIa32.dsc | 17 +++++
> OvmfPkg/OvmfPkgIa32.fdf | 4 ++
> OvmfPkg/OvmfPkgIa32X64.dsc | 17 +++++
> OvmfPkg/OvmfPkgIa32X64.fdf | 4 ++
> OvmfPkg/OvmfPkgX64.dsc | 17 +++++
> OvmfPkg/OvmfPkgX64.fdf | 4 ++
> OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf | 53 +++++++++++++++
> OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c | 84 ++++++++++++++++++++++++
> 8 files changed, 200 insertions(+)
> create mode 100644 OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf
> create mode 100644 OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c
Nice!
Reviewed-by: Laszlo Ersek <address@hidden>
- [Qemu-devel] [PATCH v3 0/7] ovmf: preliminary TPM2 support, marcandre . lureau, 2018/03/09
- [Qemu-devel] [PATCH v3 1/7] SecurityPkg/Tcg2Pei: drop PeiReadOnlyVariable from Depex, marcandre . lureau, 2018/03/09
- [Qemu-devel] [PATCH v3 3/7] OvmfPkg: simplify SecurityStubDxe.inf inclusion, marcandre . lureau, 2018/03/09
- [Qemu-devel] [PATCH v3 2/7] MdeModulePkg/Core/Pei: fix REGISITER -> REGISTER typo, marcandre . lureau, 2018/03/09
- [Qemu-devel] [PATCH v3 5/7] OvmfPkg: include Tcg2Pei module, marcandre . lureau, 2018/03/09
- [Qemu-devel] [PATCH v3 4/7] OvmfPkg: add customized Tcg2ConfigPei clone, marcandre . lureau, 2018/03/09
- Re: [Qemu-devel] [PATCH v3 4/7] OvmfPkg: add customized Tcg2ConfigPei clone,
Laszlo Ersek <=
- [Qemu-devel] [PATCH v3 6/7] OvmfPkg: include Tcg2Dxe module, marcandre . lureau, 2018/03/09
- [Qemu-devel] [PATCH v3 7/7] OvmfPkg: plug DxeTpm2MeasureBootLib into SecurityStubDxe, marcandre . lureau, 2018/03/09
- Re: [Qemu-devel] [edk2] [PATCH v3 0/7] ovmf: preliminary TPM2 support, Marc-André Lureau, 2018/03/09
- Re: [Qemu-devel] [edk2] [PATCH v3 0/7] ovmf: preliminary TPM2 support, Laszlo Ersek, 2018/03/09