qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to make "-net" less prominent
Date: Fri, 9 Mar 2018 16:33:42 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/09/2018 04:07 PM, Thomas Huth wrote:

... but looks like I even got it wrong - it should be "--device e1000",
without "=". Will fix it.

Really?  As I understand it, both long-opt spellings work ('--long=opt'
as one arg, and '--long' 'opt' as two args).  So the only reason to drop
'=' would be consistency with other examples.

Well, that would be true if we used getopt_long_only(). But we don't (we stupidly rolled our own command line parser, meaning it has quirks that are different from everything else that uses the standardized parser).


$ qemu-system-x86_64 --device=e1000
qemu-system-x86_64: --device=e1000: invalid option

Does at least not work for me.

Maybe our QemuOpts parser should be taught to make it work. But that's orthogonal, so you are right that for now we just always document things as the two-arg form, since the one-arg form with '=' isn't implemented.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]