Re: [Qemu-devel] [PATCH v2 15/23] RISC-V: Use memory_region_is_ram in pte update

[Philippe Mathieu-Daudé]

On 03/09/2018 05:12 AM, Michael Clark wrote:
> After reading cpu_physical_memory_write and friends, it seems
> that memory_region_is_ram is a more appropriate interface,
> and matches the intent of the code that is calling it.
> 
> Cc: Sagar Karandikar <address@hidden>
> Cc: Bastian Koppelmann <address@hidden>
> Signed-off-by: Michael Clark <address@hidden>
> Signed-off-by: Palmer Dabbelt <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  target/riscv/helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/riscv/helper.c b/target/riscv/helper.c
> index 162d5ec..fc550d3 100644
> --- a/target/riscv/helper.c
> +++ b/target/riscv/helper.c
> @@ -235,7 +235,7 @@ restart:
>                  rcu_read_lock();
>                  mr = address_space_translate(cs->as, pte_addr,
>                      &addr1, &l, false);
> -                if (memory_access_is_direct(mr, true)) {
> +                if (memory_region_is_ram(mr)) {
>                      target_ulong *pte_pa =
>                          qemu_map_ram_ptr(mr->ram_block, addr1);
>  #if TCG_OVERSIZED_GUEST
>