Re: [Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8632a757c2 linux-user: init_guest_space: Add a comment about search strategy
ba6b6b2c88 linux-user: init_guest_space: Don't try to align if we'll reject it
28c11cb5f4 linux-user: init_guest_space: Clean up control flow a bit
07bb6931a7 linux-user: init_guest_commpage: Add a comment about size check
861df567d3 linux-user: init_guest_space: Clarify page alignment logic
122cb68f59 linux-user: init_guest_space: Correctly handle guest_start in 
commpage initialization
5300fd1f33 linux-user: init_guest_space: Clean up if we can't initialize the 
commpage
e2363e1081 linux-user: Rename validate_guest_space => init_guest_commpage
8d0f3a270b linux-user: Use #if to only call validate_guest_space for 32-bit ARM 
target
f56dd5f653 qemu-binfmt-conf.sh: add qemu-xtensa
f15bd1b0d6 linux-user: drop unused target_msync function
aabcc316af linux-user: fix target_mprotect/target_munmap error return values
cf497a7694 linux-user: fix assertion in shmdt
b2cf1df32c linux-user: fix mmap/munmap/mprotect/mremap/shmat
5e5ec53930 linux-user: Support f_flags in statfs when available.
a80208de3f linux-user: allows to use "--systemd ALL" with qemu-binfmt-conf.sh
f0f44061ce linux-user: Remove the unused "not implemented" signal handling stubs
9b371941f0 linux-user: Drop unicore32 code

=== OUTPUT BEGIN ===
Checking PATCH 1/18: linux-user: Drop unicore32 code...
Checking PATCH 2/18: linux-user: Remove the unused "not implemented" signal 
handling stubs...
Checking PATCH 3/18: linux-user: allows to use "--systemd ALL" with 
qemu-binfmt-conf.sh...
Checking PATCH 4/18: linux-user: Support f_flags in statfs when available....
ERROR: code indent should never use tabs
#57: FILE: linux-user/syscall_defs.h:2216:
+^Iint32_t^I^I^If_flags;$

ERROR: code indent should never use tabs
#58: FILE: linux-user/syscall_defs.h:2217:
+^Iint32_t^I^I^If_spare[5];$

ERROR: code indent should never use tabs
#67: FILE: linux-user/syscall_defs.h:2233:
+^Iabi_long^I^If_flags;$

ERROR: code indent should never use tabs
#68: FILE: linux-user/syscall_defs.h:2234:
+^Iabi_long^I^If_spare[5];$

ERROR: code indent should never use tabs
#77: FILE: linux-user/syscall_defs.h:2250:
+^Iuint32_t^If_flags;$

ERROR: code indent should never use tabs
#78: FILE: linux-user/syscall_defs.h:2251:
+^Iuint32_t^If_spare[5];$

ERROR: code indent should never use tabs
#87: FILE: linux-user/syscall_defs.h:2267:
+^Iabi_long f_flags;$

ERROR: code indent should never use tabs
#88: FILE: linux-user/syscall_defs.h:2268:
+^Iabi_long f_spare[4];$

ERROR: code indent should never use tabs
#97: FILE: linux-user/syscall_defs.h:2282:
+^Iabi_long f_flags;$

ERROR: code indent should never use tabs
#98: FILE: linux-user/syscall_defs.h:2283:
+^Iabi_long f_spare[4];$

ERROR: code indent should never use tabs
#128: FILE: linux-user/syscall_defs.h:2328:
+^Iuint32_t f_flags;$

ERROR: code indent should never use tabs
#129: FILE: linux-user/syscall_defs.h:2329:
+^Iuint32_t f_spare[4];$

ERROR: code indent should never use tabs
#138: FILE: linux-user/syscall_defs.h:2343:
+^Iuint32_t f_flags;$

ERROR: code indent should never use tabs
#139: FILE: linux-user/syscall_defs.h:2344:
+^Iuint32_t f_spare[4];$

total: 14 errors, 0 warnings, 112 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/18: linux-user: fix mmap/munmap/mprotect/mremap/shmat...
Checking PATCH 6/18: linux-user: fix assertion in shmdt...
Checking PATCH 7/18: linux-user: fix target_mprotect/target_munmap error return 
values...
Checking PATCH 8/18: linux-user: drop unused target_msync function...
Checking PATCH 9/18: qemu-binfmt-conf.sh: add qemu-xtensa...
WARNING: line over 80 characters
#38: FILE: scripts/qemu-binfmt-conf.sh:111:
+xtensa_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x5e\x00'

ERROR: line over 90 characters
#39: FILE: scripts/qemu-binfmt-conf.sh:112:
+xtensa_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

WARNING: line over 80 characters
#42: FILE: scripts/qemu-binfmt-conf.sh:115:
+xtensaeb_magic='\x7fELF\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x5e'

ERROR: line over 90 characters
#43: FILE: scripts/qemu-binfmt-conf.sh:116:
+xtensaeb_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

total: 2 errors, 2 warnings, 26 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/18: linux-user: Use #if to only call validate_guest_space for 
32-bit ARM target...
Checking PATCH 11/18: linux-user: Rename validate_guest_space => 
init_guest_commpage...
Checking PATCH 12/18: linux-user: init_guest_space: Clean up if we can't 
initialize the commpage...
Checking PATCH 13/18: linux-user: init_guest_space: Correctly handle 
guest_start in commpage initialization...
Checking PATCH 14/18: linux-user: init_guest_space: Clarify page alignment 
logic...
Checking PATCH 15/18: linux-user: init_guest_commpage: Add a comment about size 
check...
Checking PATCH 16/18: linux-user: init_guest_space: Clean up control flow a 
bit...
Checking PATCH 17/18: linux-user: init_guest_space: Don't try to align if we'll 
reject it...
Checking PATCH 18/18: linux-user: init_guest_space: Add a comment about search 
strategy...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden