[Qemu-devel] [PATCH RFC] scripts/checkpatch.pl: Bug fix

[Su Hang]

Bug fix: checkpatch.pl stops complaining about following pattern:
"""
do {
    //do somethins;
} while (conditions);
"""

Two things need to be mentioned:
1) Before I casue this bug, checkpatch.pl will raise a wrong
complain:
"""
ERROR: braces {} are necessary even for single statement blocks
+    for (i == 0; i < 0; ++i)
+    {
+        ;
+    } else
"""
In this patch, this wrong complain get fixed.

2) Becasue all(`if`, `while`, `for`) check have been done in this
`if` block(Line: 2356), and this block contains following statement:
""" Line: 2379
$suppress_ifbraces{$ln + $offset} = 1;
"""
So the block after this block may never run:
""" Line: 2415
if (!defined $suppress_ifbraces{$linenr - 1} &&
        $line =~ /\b(if|while|for|else)\b/ &&
        $line !~ /\#\s*if/ &&
        $line !~ /\#\s*else/) {
"""
But I think, maybe it's ok, becasue all check has been done by
up block. I'm not sure, please give me some advice.

Signed-off-by: Su Hang <address@hidden>
---
 scripts/checkpatch.pl | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d1fe79bcc47c..2ca833f22e5a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2355,6 +2355,18 @@ sub process {
 # check for missing bracing around if etc
                if ($line =~ /(^.*)\b(?:if|while|for)\b/ &&
                        $line !~ /\#\s*if/) {
+                       my $allowed = 0;
+
+                       # Check the pre-context.
+                       if ($line =~ /(\}.*?)$/) {
+                               my $pre = $1;
+
+                               if ($line !~ /else/) {
+                                       print "APW: ALLOWED: pre<$pre> 
line<$line>\n"
+                                               if $dbg_adv_apw;
+                                       $allowed = 1;
+                               }
+                       }
                        my ($level, $endln, @chunks) =
                                ctx_statement_full($linenr, $realcnt, 1);
                         if ($dbg_adv_apw) {
@@ -2363,7 +2375,6 @@ sub process {
                                 if $#chunks >= 1;
                         }
                        if ($#chunks >= 0 && $level == 0) {
-                               my $allowed = 0;
                                my $seen = 0;
                                my $herectx = $here . "\n";
                                my $ln = $linenr - 1;
@@ -2407,7 +2418,7 @@ sub process {
                                             $allowed = 1;
                                        }
                                }
-                               if ($seen != ($#chunks + 1)) {
+                               if ($seen != ($#chunks + 1) && !$allowed) {
                                        ERROR("braces {} are necessary for all 
arms of this statement\n" . $herectx);
                                }
                        }
--
2.7.4