Re: [Qemu-devel] [PATCH for-2.12] qapi: Force UTF8 encoding when parsing qapi files

[Daniel P . Berrangé]

On Mon, Mar 19, 2018 at 03:50:40PM -0500, Eric Blake wrote:
> Commit d4e5ec877 already fixed things to work around Python 3's
> lame bug of having LC_ALL=C not be 8-bit clean, when parsing the
> main QMP qapi files; but failed to do likewise in the tests
> directory.  As a result, running 'LC_ALL=C make check' fails on
> escape-too-big and unicode-str when using python 3 with a nasty
> stack trace instead of the intended graceful error message that
> QAPI doesn't yet support 8-bit data (the two tests contain
> Unicode é, when parsed in UTF-8; they represent something
> different when parsed in a proper single-byte C locale, but that
> doesn't matter to the error message printed out, provided that
> brain-dead Python hasn't first choked on the input instead of
> being 8-bit clean).
> 
> Ideally, we'd teach the qapi generator scripts to automatically
> slurp things in using UTF-8 regardless of locale, and to honor
> content that is not limited to 7 bit data rather than gracefully
> erroring out; but until then, since our graceful error depends
> on python parsing 8-bit data (even if nothing we generate uses
> 8-bit data), our quick fix is to use the right locale when
> running these tests.
> 
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> 
> Will go through my QAPI tree for post-freeze bug fixes
> 
>  tests/Makefile.include | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <address@hidden>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|