[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] chardev-socket: remove useless if
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH] chardev-socket: remove useless if |
|
Date: |
Wed, 21 Mar 2018 11:25:47 +0800 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Mar 20, 2018 at 04:18:57PM +0100, Paolo Bonzini wrote:
> This trips Coverity, which believes the subsequent qio_channel_create_watch
> can dereference a NULL pointer. In reality, tcp_chr_connect's callers
> all have s->ioc properly initialized, since they are all rooted at
> tcp_chr_new_client.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
(maybe replacing with an assertion would be nicer? No big deal.)
Reviewed-by: Peter Xu <address@hidden>
--
Peter Xu