[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12 05/12] luks: Turn another invalid asser
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12 05/12] luks: Turn another invalid assertion into check |
Date: |
Wed, 21 Mar 2018 09:31:25 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Mar 20, 2018 at 06:36:25PM +0100, Kevin Wolf wrote:
> Commit e39e959e fixed an invalid assertion in the .bdrv_length
> implementation, but left a similar assertion in place for
> .bdrv_truncate. Instead of crashing when the user requests a too large
> image size, fail gracefully.
>
> A file size of exactly INT64_MAX caused failure before, but is actually
> legal.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/crypto.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH for-2.12 02/12] vdi: Fix build with CONFIG_VDI_DEBUG, (continued)
- [Qemu-devel] [PATCH for-2.12 04/12] qemu-iotests: Enable 025 for luks, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 06/12] qemu-iotests: Test invalid resize on luks, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 05/12] luks: Turn another invalid assertion into check, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 03/12] qemu-iotests: Test vdi image creation with QMP, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 07/12] parallels: Check maximum cluster size on create, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 09/12] vhdx: Require power-of-two block size on create, Kevin Wolf, 2018/03/20
- [Qemu-devel] [PATCH for-2.12 08/12] qemu-iotests: Test parallels image creation with QMP, Kevin Wolf, 2018/03/20