[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 31/36] monitor: enable IO thread for (qmp & !mux)
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PULL 31/36] monitor: enable IO thread for (qmp & !mux) typed |
Date: |
Wed, 21 Mar 2018 17:15:27 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
* Eric Blake (address@hidden) wrote:
> On 03/21/2018 07:37 AM, Max Reitz wrote:
> > On 2018-03-12 19:36, Eric Blake wrote:
> > > From: Peter Xu <address@hidden>
> > >
> > > Start to use dedicate IO thread for QMP monitors that are not using
> > > MUXed chardev.
> > >
> > > Reviewed-by: Fam Zheng <address@hidden>
> > > Reviewed-by: Stefan Hajnoczi <address@hidden>
> > > Signed-off-by: Peter Xu <address@hidden>
> > > Message-Id: <address@hidden>
> > > Signed-off-by: Eric Blake <address@hidden>
> > > ---
> > > monitor.c | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > It seems the iotests aren't quite ready for this change (breakage in
> > 040, 041, 051, 060, 085, 087, 093, 095, 109, 124, 127, 132, 136, 144,
> > 148, 152, 182, 183, 185, 186; and 030 hangs).
>
> Serves me right for not testing iotests on my qapi tree as rigoursly as I do
> on my NBD tree. Fixing this during freeze is acceptable, although I'd like
> it if Peter Xu can take a look instead of just me.
>
> (And still a bummer that iotests aren't being run by 'make check' or CLI to
> have caught it earlier?)
I'm guessing from those that 030 is the easiest to try and debug because
it hangs and you get a nice backtrace. The others are a bit mysterious
(I think it's 042 which just has an f in one place in the output rather
than a .)
Dave
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PULL 21/36] qmp: introduce QMPCapability, (continued)
- [Qemu-devel] [PULL 21/36] qmp: introduce QMPCapability, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 30/36] qmp: isolate responses into io thread, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 15/36] qobject: let object_property_get_str() use new API, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 23/36] monitor: let suspend_cnt be thread safe, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 27/36] monitor: send event when command queue full, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 25/36] monitor: separate QMP parser and dispatcher, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 31/36] monitor: enable IO thread for (qmp & !mux) typed, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 33/36] tests: qmp-test: verify command batching, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 35/36] block/accounting: introduce latency histogram, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 36/36] qapi: add block latency histogram interface, Eric Blake, 2018/03/12
- [Qemu-devel] [PULL 07/36] qapi: Replace qobject_to_X(o) by qobject_to(X, o), Eric Blake, 2018/03/12
- Re: [Qemu-devel] [PULL 00/36] QAPI patches for 2018-03-12, 2.12 softfreeze, Peter Maydell, 2018/03/13