[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] ide: push end_transfer callback to ide_tran
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/5] ide: push end_transfer callback to ide_transfer_halt |
|
Date: |
Wed, 21 Mar 2018 14:05:29 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/21/2018 01:39 AM, Paolo Bonzini wrote:
> On 20/03/2018 23:11, John Snow wrote:
>> Seems sane, with some lingering questions about what the PIO Setup FIS
>> is supposed to do to begin with still remaining.
>
> I agree here too. Smashing the ATA and controller in the same device
> makes things tricky, so I tried to make these patches pure code motion,
> as much as I could.
>
> Paolo
>
Oh, I understand. There's a reason I haven't touched the PIO Setup FIS
much when I cleaned the device up before.
I was just hoping you'd magically know more about it.
:)