[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12 v3 2/2] iotests: Update 186 after commi
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12 v3 2/2] iotests: Update 186 after commit ac64273c66ab136c44043259162 |
Date: |
Thu, 22 Mar 2018 14:42:27 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 22 Mar 2018 02:17:23 PM CET, Eric Blake wrote:
>> --- a/tests/qemu-iotests/186.out
>> +++ b/tests/qemu-iotests/186.out
>> @@ -404,7 +404,7 @@ Testing: -drive if=floppy
>> QEMU X.Y.Z monitor - type 'help' for more information
>> (qemu) info block
>> floppy0: [not inserted]
>> - Attached to: /machine/unattached/device[17]
>> + Attached to: /machine/unattached/device[13]
>
> It looks like this name is quite flexible; would it not be better to
> enhance 186 to sed out the name (s/Attached to:.*/Attached to: PATH/)
> and then adjust the .out so that it is no longer sensitive to these
> types of internal renames?
That's a good idea, shall we hide the number only? (i.e. leave
"/machine/unattached/device[INDEX]" or something like that), or can the
rest of the path also change?
Berto