[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed |
Date: |
Fri, 23 Mar 2018 13:10:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
As Max Reitz said, this breaks several qemu iotests. I can reproduce that on
s390
e.g. with ./check -qcow2 030 in the qemu-iotest.
Why was this merged?
On 03/09/2018 10:00 AM, Peter Xu wrote:
> Start to use dedicate IO thread for QMP monitors that are not using
> MUXed chardev.
>
> Reviewed-by: Fam Zheng <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> monitor.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/monitor.c b/monitor.c
> index c6de5f123e..9e8ee2ed14 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -36,6 +36,7 @@
> #include "net/slirp.h"
> #include "chardev/char-fe.h"
> #include "chardev/char-io.h"
> +#include "chardev/char-mux.h"
> #include "ui/qemu-spice.h"
> #include "sysemu/numa.h"
> #include "monitor/monitor.h"
> @@ -4533,8 +4534,10 @@ static void monitor_qmp_setup_handlers_bh(void *opaque)
> void monitor_init(Chardev *chr, int flags)
> {
> Monitor *mon = g_malloc(sizeof(*mon));
> + /* Enable IOThread for QMPs that are not using MUX chardev backends. */
> + bool use_io_thr = (!CHARDEV_IS_MUX(chr)) && (flags &
> MONITOR_USE_CONTROL);
>
> - monitor_data_init(mon, false, false);
> + monitor_data_init(mon, false, use_io_thr);
>
> qemu_chr_fe_init(&mon->chr, chr, &error_abort);
> mon->flags = flags;
>
[Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed, Peter Xu, 2018/03/09
- Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed,
Christian Borntraeger <=
- Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed, Peter Xu, 2018/03/23
- Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed, Christian Borntraeger, 2018/03/23
- Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed, Peter Xu, 2018/03/23
- Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed, Peter Maydell, 2018/03/23
- Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed, Christian Borntraeger, 2018/03/23
- Re: [Qemu-devel] [PATCH v8 20/23] monitor: enable IO thread for (qmp & !mux) typed, Peter Xu, 2018/03/23
[Qemu-devel] [PATCH v8 21/23] qmp: add command "x-oob-test", Peter Xu, 2018/03/09
[Qemu-devel] [PATCH v8 22/23] tests: qmp-test: verify command batching, Peter Xu, 2018/03/09