[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefault
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults" |
Date: |
Fri, 23 Mar 2018 16:03:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 23/03/2018 15:28, Peter Maydell wrote:
>> Note it's a null "backend", not necessarily a null "character device".
>> Your proposal, namely ensuring that be->chr == NULL is handled properly
>> in qemu_chr_fe_init, would be just fine.
>
> Hmm, the chardev layer code seems to have more ends than I expect.
> The "frontend" is the UART model, right, and I thought the
> "backend" was the TCP/UDP/serial port/stdio/etc end of things,
> but those seem to be Chardevs? If those aren't the backend,
> then what is?
The naming of Chardev/CharBackend was modeled after
BlockDriverState/BlockBackend, and it's not great but at least it's
consistent. :/
The CharBackend struct essentially connects a Chardev and its user. It
ought to be possible for the Chardev to be NULL.
Paolo
> What I'd like, anyway, is that every UART model can cope with being
> setup with a NULL 'chardev' property, and ideally that that doesn't
> require a lot of extra code per-UART, and doesn't require each UART
> to create a TYPE_CHARDEV_NULL.
>
- [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults", Thomas Huth, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults", Bastian Koppelmann, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults", Peter Maydell, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults", Thomas Huth, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults", Peter Maydell, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults", Paolo Bonzini, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults", Peter Maydell, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults", Paolo Bonzini, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults", Peter Maydell, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12] hw/riscv: Fix crashes with "-nodefaults",
Paolo Bonzini <=