[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state |
Date: |
Fri, 23 Mar 2018 18:27:32 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Mon, Mar 12, 2018 at 02:11:10PM +0100, Igor Mammedov wrote:
> Ban it for now, if someone would need it to work early,
> one would have to implement checks if HMP command is valid
> at preconfig state.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> v4:
> * v3 was only printing error but not preventing command execution,
> Fix it by returning after printing error message.
> ("Dr. David Alan Gilbert" <address@hidden>)
> ---
> monitor.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/monitor.c b/monitor.c
> index a4417f2..ea0ca57 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3104,6 +3104,11 @@ static void handle_hmp_command(Monitor *mon, const
> char *cmdline)
>
> trace_handle_hmp_command(mon, cmdline);
>
> + if (runstate_check(RUN_STATE_PRECONFIG)) {
> + monitor_printf(mon, "HMP not available in preconfig state\n");
> + return;
Not even the "cont" command? It would be useful for testing
-preconfig.
--
Eduardo
[Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state, Igor Mammedov, 2018/03/12
- Re: [Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state,
Eduardo Habkost <=
[Qemu-devel] [PATCH v4 1/9] numa: postpone options post-processing till machine_run_board_init(), Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option, Igor Mammedov, 2018/03/12