[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12 1/4] Revert "monitor: enable IO thread
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12 1/4] Revert "monitor: enable IO thread for (qmp & !mux) typed" |
Date: |
Sat, 24 Mar 2018 09:01:15 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Mar 23, 2018 at 10:49:31AM -0500, Eric Blake wrote:
> On 03/23/2018 09:08 AM, Peter Xu wrote:
> > This reverts commit 3fd2457d18edf5736f713dfe1ada9c87a9badab1.
> >
> > Signed-off-by: Peter Xu <address@hidden>
>
> Not fatal to taking this patch as-is, but it's always nice to include a
> rationale when reverting, something along the lines of:
>
> It turns out that enabling OOB caused several iotests to break; disabling
> OOB is the fastest and safest approach for reducing the risk of a broken
> release, while working on the fixes for the problems uncovered.
>
> (Probably similar comments will be needed on the remaining patches...)
Yes. I saw the pull, thanks for adding those info into commit messages.
--
Peter Xu
- [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Peter Xu, 2018/03/23
- [Qemu-devel] [PATCH for-2.12 1/4] Revert "monitor: enable IO thread for (qmp & !mux) typed", Peter Xu, 2018/03/23
- [Qemu-devel] [PATCH for-2.12 2/4] Revert "tests: qmp-test: add oob test", Peter Xu, 2018/03/23
- [Qemu-devel] [PATCH for-2.12 3/4] Revert "tests: qmp-test: verify command batching", Peter Xu, 2018/03/23
- [Qemu-devel] [PATCH for-2.12 4/4] tests: partly revert "qmp: introduce QMPCapability", Peter Xu, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Peter Xu, 2018/03/23
- Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests, Eric Blake, 2018/03/23