[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12 3/8] monitor: new parameter "x-oob"
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12 3/8] monitor: new parameter "x-oob" |
Date: |
Mon, 26 Mar 2018 17:13:51 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Mar 26, 2018 at 11:10:30AM +0200, Marc-André Lureau wrote:
[...]
> > @@ -4568,12 +4569,26 @@ static void monitor_qmp_setup_handlers_bh(void
> > *opaque)
> > void monitor_init(Chardev *chr, int flags)
> > {
> > Monitor *mon = g_malloc(sizeof(*mon));
> > + bool use_readline = flags & MONITOR_USE_READLINE;
> > + bool use_oob = flags & MONITOR_USE_OOB;
> > +
> > + if (use_oob) {
> > + if (CHARDEV_IS_MUX(chr)) {
> > + error_report("Monitor Out-Of-Band is not supported with "
> > + "MUX typed chardev backend");
> > + exit(1);
> > + }
> > + if (use_readline) {
> > + error_report("Monitor Out-Of-band is only supported by QMP");
> > + exit(1);
> > + }
> > + }
>
> I would rather see the error reporting / exit in vl.c:mon_init_func()
> function, to have a single place for exit()
But there can be other callers for monitor_init() so I would assume
checking it here would be safer (though for now indeed mon_init_func()
is the only one that can pass OOB flag in).
[...]
> Other than that, it looks fine.
> Reviewed-by: Marc-André Lureau <address@hidden>
Thanks for your quick reviews!
--
Peter Xu
- [Qemu-devel] [PATCH for-2.12 0/8] Monitor: some oob related patches (fixes, new param, tests), Peter Xu, 2018/03/26
- [Qemu-devel] [PATCH for-2.12 1/8] qmp: fix qmp_capabilities error regression, Peter Xu, 2018/03/26
- [Qemu-devel] [PATCH for-2.12 2/8] qmp: cleanup qmp queues properly, Peter Xu, 2018/03/26
- [Qemu-devel] [PATCH for-2.12 3/8] monitor: new parameter "x-oob", Peter Xu, 2018/03/26
- [Qemu-devel] [PATCH for-2.12 4/8] qapi: restrict allow-oob value to be "true", Peter Xu, 2018/03/26
- [Qemu-devel] [PATCH for-2.12 5/8] tests: let qapi-schema tests detect oob, Peter Xu, 2018/03/26
- [Qemu-devel] [PATCH for-2.12 6/8] tests: add oob-test for qapi-schema, Peter Xu, 2018/03/26
- [Qemu-devel] [PATCH for-2.12 7/8] tests: introduce qtest_init_with_qmp_format(), Peter Xu, 2018/03/26