Re: [Qemu-devel] [PATCH for-2.12] hmp.c: Revert hmp_info_cpus output format

[Viktor Mihajlovski]

On 27.03.2018 16:25, Cornelia Huck wrote:
> On Tue, 27 Mar 2018 08:59:04 -0500
> Eric Blake <address@hidden> wrote:
> 
>> On 03/27/2018 07:38 AM, address@hidden wrote:
>>> From: Satheesh Rajendran <address@hidden>
>>>
>>> This commit 137b5cb6ab565cb3781d5337591e155932b4230e
>>> refactors info cpus output and changes output format from
>>> 'thread_id' to 'thread-id', this would break parsing
>>> of output in above layers like libvirt, test framework etc.
>>>
>>> This patch just reverts back output format to 'thread_id'.
>>>
>>> CC: Viktor Mihajlovski <address@hidden>
>>> Signed-off-by: Satheesh Rajendran <address@hidden>
>>> ---
>>>   hmp.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)  
>>
>> I'm not opposed to this patch (because it is a trivial way to keep older 
>> stuff working), but agree with Daniel that HMP output can change at any 
>> time, so other stuff relying on HMP should be fixed.  Libvirt is not 
>> affected, so if we DO take this into 2.12, we should update the commit 
>> message to drop mention of libvirt being impacted, maybe along the lines of:
>>
>> Commit 137b5cb6 refactored 'info cpus' output, changing 'thread_id' to 
>> 'thread-id'.  While HMP is not a stable interface, it is trivial to keep 
>> the spelling consistent for test frameworks that have not yet updated to 
>> using QMP.
>>
>> With the improved commit message,
>> Reviewed-by: Eric Blake <address@hidden>
>>
> 
> Yes, that certainly makes sense.
> 
> Reviewed-by: Cornelia Huck <address@hidden>
> 
Right. Seems I got carried away during the thread_id to thread-id
conversion.

-- 
Regards,
 Viktor Mihajlovski