Re: [Qemu-devel] [PATCH 0/4] tpm: More improvements on CRB interface

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/4] tpm: More improvements on CRB interface

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
09491e26e3 tests: Tests more flags of the CRB interface
d55c9446c4 tpm: CRB: Enforce locality is requested before processing buffer
bc0cf354f6 tpm: CRB: Reset Granted flag when relinquishing locality
d5030ad3b6 tpm: CRB: set the Idle flag by default

=== OUTPUT BEGIN ===
Checking PATCH 1/4: tpm: CRB: set the Idle flag by default...
Checking PATCH 2/4: tpm: CRB: Reset Granted flag when relinquishing locality...
Checking PATCH 3/4: tpm: CRB: Enforce locality is requested before processing 
buffer...
ERROR: suspect code indent for conditional statements (4, 9)
#35: FILE: hw/tpm/tpm_crb.c:102:
+    if (!ARRAY_FIELD_EX32(s->regs, CRB_LOC_STATE, locAssigned))
+         return TPM_CRB_NO_LOCALITY;

ERROR: braces {} are necessary for all arms of this statement
#35: FILE: hw/tpm/tpm_crb.c:102:
+    if (!ARRAY_FIELD_EX32(s->regs, CRB_LOC_STATE, locAssigned))
[...]

total: 2 errors, 0 warnings, 35 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/4: tests: Tests more flags of the CRB interface...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden