[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/xtensa: linux-user: fix fadvise64 call
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-devel] [PATCH] target/xtensa: linux-user: fix fadvise64 call |
|
Date: |
Mon, 2 Apr 2018 12:21:47 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
Le 02/04/2018 à 00:12, Max Filippov a écrit :
> fadvise64_64 on xtensa passes advice as the second argument and so must
> be handled similar to PPC.
>
> This fixes glibc testsuite tests posix/tst-posix_fadvise and
> posix/tst-posix_fadvise64.
>
> Signed-off-by: Max Filippov <address@hidden>
> ---
> linux-user/syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 924fd68efcdd..5ef517613577 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -11509,7 +11509,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
> arg1,
>
> #ifdef TARGET_NR_fadvise64_64
> case TARGET_NR_fadvise64_64:
> -#if defined(TARGET_PPC)
> +#if defined(TARGET_PPC) || defined(TARGET_XTENSA)
> /* 6 args: fd, advice, offset (high, low), len (high, low) */
> ret = arg2;
> arg2 = arg3;
>
Reviewed-by: Laurent Vivier <address@hidden>