Re: [Qemu-devel] [PATCH v2 00/17] tcg: tb_lock_removal redux v2

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/17] tcg: tb_lock_removal redux v2

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
596b0ae126 tcg: remove tb_lock
393740f4bc translate-all: remove tb_lock mention from cpu_restore_state_from_tb
1d225d49e8 cputlb: remove tb_lock from tlb_flush functions
7117367de6 translate-all: protect TB jumps with a per-destination-TB lock
1d1fd21dd7 translate-all: discard TB when tb_link_page returns an existing 
matching TB
ca22fa4417 translate-all: add page_collection assertions
50b6081956 translate-all: add page_locked assertions
5b6d7dd39f translate-all: use per-page locking in !user-mode
9fb729b4a1 translate-all: move tb_invalidate_phys_page_range up in the file
e3435070c4 translate-all: work page-by-page in tb_invalidate_phys_range_1
b7f40fb599 translate-all: remove hole in PageDesc
256fc42714 translate-all: make l1_map lockless
9bb165ec14 translate-all: iterate over TBs in a page with PAGE_FOR_EACH_TB
8a38ca3168 tcg: move tb_ctx.tb_phys_invalidate_count to tcg_ctx
c0e7a50dea tcg: track TBs with per-region BST's
812e356d97 qht: return existing entry when qht_insert fails
aa639c6e6f qht: require a default comparison function

=== OUTPUT BEGIN ===
Checking PATCH 1/17: qht: require a default comparison function...
Checking PATCH 2/17: qht: return existing entry when qht_insert fails...
Checking PATCH 3/17: tcg: track TBs with per-region BST's...
Checking PATCH 4/17: tcg: move tb_ctx.tb_phys_invalidate_count to tcg_ctx...
Checking PATCH 5/17: translate-all: iterate over TBs in a page with 
PAGE_FOR_EACH_TB...
ERROR: braces {} are necessary for all arms of this statement
#50: FILE: accel/tcg/translate-all.c:119:
+    for (n = (head) & 1, tb = (TranslationBlock *)((head) & ~1);        \
[...]

total: 1 errors, 0 warnings, 168 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/17: translate-all: make l1_map lockless...
Checking PATCH 7/17: translate-all: remove hole in PageDesc...
Checking PATCH 8/17: translate-all: work page-by-page in 
tb_invalidate_phys_range_1...
Checking PATCH 9/17: translate-all: move tb_invalidate_phys_page_range up in 
the file...
Checking PATCH 10/17: translate-all: use per-page locking in !user-mode...
Checking PATCH 11/17: translate-all: add page_locked assertions...
Checking PATCH 12/17: translate-all: add page_collection assertions...
Checking PATCH 13/17: translate-all: discard TB when tb_link_page returns an 
existing matching TB...
Checking PATCH 14/17: translate-all: protect TB jumps with a per-destination-TB 
lock...
Checking PATCH 15/17: cputlb: remove tb_lock from tlb_flush functions...
Checking PATCH 16/17: translate-all: remove tb_lock mention from 
cpu_restore_state_from_tb...
Checking PATCH 17/17: tcg: remove tb_lock...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden