[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.13 1/3] net: Remove the deprecated "vla
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.13 1/3] net: Remove the deprecated "vlan" parameter |
|
Date: |
Fri, 6 Apr 2018 16:17:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 06/04/2018 15:37, Thomas Huth wrote:
> It's been marked as deprecated since QEMU v2.9.0, so that should have
> been enough time for everybody to switch to the modern -device + -netdev
> syntax for connecting guest NICs with host network backends, or to switch
> to the "hubport" netdev in case hubs are really wanted instead.
... or to just drop unnecessary "vlan=0", which is the really common case.
>
> # @NetdevL2TPv3Options:
> #
> -# Connect the VLAN to Ethernet over L2TPv3 Static tunnel
> +# Configure an Ethernet over L2TPv3 Static tunnel.
> #
Since you are at it, probably remove "Static"? I don't see the point
really.
> or the netdev 'nd' (for pluggable\n"
> " NICs please use '-device devtype,netdev=nd' instead)\n"
Maybe remove this if -net is prominently marked deprecated? And mention
using -nic instead of "-net nic,netdev=...".
Paolo
> Buglink: https://bugs.launchpad.net/qemu/+bug/658904
> Signed-off-by: Thomas Huth <address@hidden>