Re: [Qemu-devel] [PATCH v2 09/17] target/mips: convert to TranslatorOps

[Richard Henderson]

On 04/07/2018 04:19 AM, Emilio G. Cota wrote:
> Notes:
> 
> - DISAS_TOO_MANY replaces the former "break" in the translation loop.
>   However, care must be taken not to overwrite a previous condition
>   in is_jmp; that's why in translate_insn we first check is_jmp and
>   return if it's != DISAS_NEXT.
> 
> - Added an assert in translate_insn, before exiting due to an exception,
>   to make sure that is_jmp is set to DISAS_EXCP (the exception generation
>   function always sets it.)
> 
> - Added an assert for the default case in is_jmp's switch.
> 
> Cc: Aurelien Jarno <address@hidden>
> Cc: Yongbok Kim <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  target/mips/translate.c | 227 
> ++++++++++++++++++++++++------------------------
>  1 file changed, 113 insertions(+), 114 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~