[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/17] target/openrisc: convert to Translator
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/17] target/openrisc: convert to TranslatorOps |
Date: |
Tue, 10 Apr 2018 14:23:29 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/07/2018 04:19 AM, Emilio G. Cota wrote:
> Notes:
>
> - Changed the num_insns test in insn_start to check for
> dc->base.num_insns > 1, since when tb_start is first
> called in a TB, base.num_insns is already set to 1.
>
> - Removed DISAS_NEXT from the switch in tb_stop; use
> DISAS_TOO_MANY instead.
>
> - Added an assert_not_reached on tb_stop for DISAS_NEXT
> and the default case.
>
> - Merged the two separate log_target_disas calls into the
> disas_log op.
>
> Cc: Stafford Horne <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/openrisc/translate.c | 163
> +++++++++++++++++++++-----------------------
> 1 file changed, 79 insertions(+), 84 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v2 00/17] Translation loop conversion for sh4/sparc/mips/s390x/openrisc/riscv targets, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 05/17] target/sparc: convert to TranslatorOps, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 03/17] target/sparc: convert to DisasJumpType, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 02/17] target/sh4: convert to TranslatorOps, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 14/17] target/openrisc: convert to TranslatorOps, Emilio G. Cota, 2018/04/06
- Re: [Qemu-devel] [PATCH v2 14/17] target/openrisc: convert to TranslatorOps,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 13/17] target/openrisc: convert to DisasContextBase, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 04/17] target/sparc: convert to DisasContextBase, Emilio G. Cota, 2018/04/06
- [Qemu-devel] [PATCH v2 06/17] target/mips: convert to DisasJumpType, Emilio G. Cota, 2018/04/06
[Qemu-devel] [PATCH v2 08/17] target/mips: use *ctx for DisasContext, Emilio G. Cota, 2018/04/06