Re: [Qemu-devel] [PATCH v7 4/8] migration: Create socket-address parameter

[Daniel P . Berrangé]

On Thu, Apr 12, 2018 at 02:09:33PM +0100, Dr. David Alan Gilbert wrote:
> * Juan Quintela (address@hidden) wrote:
> > It will be used to store the uri parameters. We want this only for
> > tcp, so we don't set it for other uris.  We need it to know what port
> > is migration running.
> > 
> > Signed-off-by: Juan Quintela <address@hidden>
> > 
> > --
> > 
> > This used to be uri parameter, but it has so many troubles to
> > reproduce that it don't just make sense.
> > 
> > This used to be a port parameter.  I was asked to move to
> > SocketAddress, done.
> > I also merged the setting of the migration tcp port in this one
> > because now I need to free the address, and this makes it easier.
> > This used to be x-socket-address with a single direction, now it is a
> > list of addresses.
> 
> Is there a reason it's a parameter rather than just an entry in
> MigrationInfo?

I imagine it is a side-effect of earlier versions of this patch
which used the migration parameter setter method. Having it in
the MigrationInfo does seem reasonable to me since this is not
a tunable parameter.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|