[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with e
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites |
Date: |
Thu, 19 Apr 2018 17:25:38 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
Hi Ian,
On 04/19/2018 01:45 PM, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Daniel P. Berrange <address@hidden>
> CC: Michael Tokarev <address@hidden>
> ---
> v7: New patch
> ---
> os-posix.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/os-posix.c b/os-posix.c
> index 0f59566..d4cf466 100644
> --- a/os-posix.c
> +++ b/os-posix.c
> @@ -129,7 +129,7 @@ void os_set_proc_name(const char *s)
> exit(1);
> }
> #else
> - fprintf(stderr, "Change of process name not supported by your OS\n");
> + error_report("Change of process name not supported by your OS\n");
removing the trailing "\n":
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> exit(1);
> #endif
> }
> @@ -243,7 +243,7 @@ static void change_root(void)
> {
> if (chroot_dir) {
> if (chroot(chroot_dir) < 0) {
> - fprintf(stderr, "chroot failed\n");
> + error_report("chroot failed");
> exit(1);
> }
> if (chdir("/")) {
>
- [Qemu-devel] [PATCH 06/16] xen: destroy_hvm_domain: Move reason into a variable, (continued)
- [Qemu-devel] [PATCH 06/16] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 08/16] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 13/16] xen: Expect xenstore write to fail when restricted, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 04/16] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 07/16] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites, Ian Jackson, 2018/04/19
- Re: [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 10/16] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 11/16] xen: Use newly added dmops for mapping VGA memory, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 02/16] AccelClass: Introduce accel_setup_post, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 12/16] xen: Remove now-obsolete xen_xc_domain_add_to_physmap, Ian Jackson, 2018/04/19
- [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report, Ian Jackson, 2018/04/19