[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] block: BLK_PERM_WRITE includes
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] block: BLK_PERM_WRITE includes ..._UNCHANGED |
|
Date: |
Fri, 20 Apr 2018 15:22:37 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-04-20 14:04, Alberto Garcia wrote:
> On Mon 16 Apr 2018 06:58:42 PM CEST, Max Reitz wrote:
>> Currently we never actually check whether the WRITE_UNCHANGED
>> permission has been taken for unchanging writes. But the one check that
>> is commented out checks both WRITE and WRITE_UNCHANGED; and considering
>> that WRITE_UNCHANGED is already documented as being weaker then WRITE,
>> we should probably explicitly document WRITE to include WRITE_UNCHANGED.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>
> Reviewed-by: Alberto Garcia <address@hidden>
>
> s/then/than/ as Stefan mentioned.
Yep, will fix.
Thanks for reviewing!
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/9] block: Add COR filter driver, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 2/9] block: BLK_PERM_WRITE includes ..._UNCHANGED, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 1/9] block: Add COR filter driver, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 3/9] block: Add BDRV_REQ_WRITE_UNCHANGED flag, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 4/9] block: Set BDRV_REQ_WRITE_UNCHANGED for COR writes, Max Reitz, 2018/04/16
- [Qemu-devel] [PATCH 5/9] block/quorum: Support BDRV_REQ_WRITE_UNCHANGED, Max Reitz, 2018/04/16