[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v4 06/13] block: Generalize should_
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v4 06/13] block: Generalize should_update_child() rule |
Date: |
Fri, 20 Apr 2018 15:29:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-04-20 10:36, Alberto Garcia wrote:
> On Wed 11 Apr 2018 08:54:18 PM CEST, Max Reitz wrote:
>> index c4dd1d4bb8..8d63a1b0c1 100644
>> --- a/include/block/block_int.h
>> +++ b/include/block/block_int.h
>> @@ -616,6 +616,8 @@ struct BdrvChild {
>> QLIST_ENTRY(BdrvChild) next_parent;
>> };
>>
>> +typedef QLIST_HEAD(BdrvChildList, BdrvChild) BdrvChildList;
>> +
>
> I forgot to mention this in a previous e-mail, but what's this used for?
Extremely good question. grep says it isn't used for anything. I'm
inclined to believe grep (especially considering the fact that
everything compiles without error after removing it).
I suppose I had some local version where I needed such a type (probably
because I didn't deem QLIST_FOREACH_SAFE() to be sufficiently safe, so I
needed to copy the list somewhere else, or I don't know...), and then I
found a way around it, removed the code, but forgot the type in the header.
Will remove in v5.
Thank you for reviewing!
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 01/13] block/mirror: Pull out mirror_perform(), (continued)
- [Qemu-devel] [PATCH v4 01/13] block/mirror: Pull out mirror_perform(), Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 03/13] block/mirror: Use CoQueue to wait on in-flight ops, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 02/13] block/mirror: Convert to coroutines, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 04/13] block/mirror: Wait for in-flight op conflicts, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 05/13] block/mirror: Use source as a BdrvChild, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 06/13] block: Generalize should_update_child() rule, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 07/13] hbitmap: Add @advance param to hbitmap_iter_next(), Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 08/13] test-hbitmap: Add non-advancing iter_next tests, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 09/13] block/dirty-bitmap: Add bdrv_dirty_iter_next_area, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 10/13] block/mirror: Add MirrorBDSOpaque, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 12/13] block/mirror: Add copy mode QAPI interface, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 11/13] block/mirror: Add active mirroring, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 13/13] iotests: Add test for active mirroring, Max Reitz, 2018/04/11